Skip to content

test: ensure error function call on inspector disabled #23586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
madeinjam wants to merge 3 commits into from
Closed

test: ensure error function call on inspector disabled #23586

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24f8b6d
lib: migrate from process.binding to internalBinding
madeinjam Oct 12, 2018
2431bca
test: ensure error function call on inspector disabled
madeinjam Oct 12, 2018
32a8115
test: remove the process variable back up
madeinjam Oct 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib: migrate from process.binding to internalBinding 
We are migrating towards using internalBinding(\'options\').getOptions()
instead of process.binding(\'config\') to access the value of the
--experimental-vm-modules command line option.
  • Loading branch information
@madeinjam
madeinjam committed Oct 12, 2018
commit 24f8b6dc0d6aa7506c189bf5e09459400b4cce38
2 changes: 1 addition & 1 deletion lib/vm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ module.exports = {
compileFunction,
};

if (process.binding('config').experimentalVMModules) {
if (internalBinding('options').getOptions('--experimental-vm-modules')) {
const { SourceTextModule } = require('internal/vm/source_text_module');
module.exports.SourceTextModule = SourceTextModule;
}