Skip to content

test: fix order of arguments passed to strictEqual #23571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eojthebrave wants to merge 1 commit into from
Closed

test: fix order of arguments passed to strictEqual #23571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix order of arguments passed to strictEqual 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.
  • Loading branch information
@eojthebrave
eojthebrave committed Oct 12, 2018
commit fe8cced056603ae7bb10634ad13aa55242eb73ca
4 changes: 2 additions & 2 deletions test/parallel/test-net-socket-local-address.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ const server = net.createServer((socket) => {

server.on('close', common.mustCall(() => {
// client and server should agree on the ports used
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts);
assert.strictEqual(2, conns);
assert.deepStrictEqual(serverRemotePorts, clientLocalPorts);
assert.strictEqual(conns, 2);
}));

server.listen(0, common.localhostIPv4, connect);
Expand Down