Skip to content

test: add async_hooks benchmark test #23556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterjreynoldsii wants to merge 2 commits into from
Closed

test: add async_hooks benchmark test #23556

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e63a9cc
test: added async-hook benchmark
peterjreynoldsii Oct 12, 2018
dbd354b
test: modified benchmark-async-hooks
peterjreynoldsii Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: added async-hook benchmark 
Added a minimalist benchmark test for the async-hooks.
  • Loading branch information
@peterjreynoldsii
peterjreynoldsii committed Oct 12, 2018
commit e63a9cc4e93e406229a094e5796cf4a5adfb9172
2 changes: 1 addition & 1 deletion lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const NO_EXCEPTION_SENTINEL = {};

function innerFail(obj) {
if (obj.message instanceof Error) throw obj.message;

Copy link
Copy Markdown
Member

@jasnell jasnell Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unnecessary whitespace change here... we can fix on landing tho

console.log('---------------------------------------------------- here is where the error is ----------------------------------------------------')
throw new AssertionError(obj);
}

Expand Down
2 changes: 2 additions & 0 deletions test/common/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ function runBenchmark(name, args, env) {
});

child.on('exit', (code, signal) => {
console.log('---------------------------------------------------- here is code ----------------------------------------------------')
console.log(code)
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
// This bit makes sure that each benchmark file is being sent settings such
Expand Down