Skip to content

test(pummel/test-net-pingpong-delay): swap expected and actual arguments in assert.strictEqual() #23542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erin-bush wants to merge 1 commit into from
Closed

test(pummel/test-net-pingpong-delay): swap expected and actual arguments in assert.strictEqual() #23542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(pummel/test-net-pingpong-delay): swap expected and actual argume… 
…nts in assert.strictEqual()
  • Loading branch information
@erin-bush
erin-bush committed Oct 12, 2018
commit 7354abf63c15a784c70dd77ce4aba7cb6564229b
24 changes: 12 additions & 12 deletions test/pummel/test-net-pingpong-delay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ function pingPongTest(port, host, on_complete) {

socket.on('data', function(data) {
console.log(data);
assert.strictEqual('PING', data);
assert.strictEqual('open', socket.readyState);
assert.strictEqual(true, count <= N);
assert.strictEqual(data, 'PING');
assert.strictEqual(socket.readyState, 'open');
assert.strictEqual(count <= N, true);
setTimeout(function() {
assert.strictEqual('open', socket.readyState);
assert.strictEqual(socket.readyState, 'open');
socket.write('PONG');
}, DELAY);
});
Expand All @@ -51,14 +51,14 @@ function pingPongTest(port, host, on_complete) {

socket.on('end', function() {
console.log('server-side socket EOF');
assert.strictEqual('writeOnly', socket.readyState);
assert.strictEqual(socket.readyState, 'writeOnly');
socket.end();
});

socket.on('close', function(had_error) {
console.log('server-side socket.end');
assert.strictEqual(false, had_error);
assert.strictEqual('closed', socket.readyState);
assert.strictEqual(had_error, false);
assert.strictEqual(socket.readyState, 'closed');
socket.server.close();
});
});
Expand All @@ -69,17 +69,17 @@ function pingPongTest(port, host, on_complete) {
client.setEncoding('utf8');

client.on('connect', function() {
assert.strictEqual('open', client.readyState);
assert.strictEqual(client.readyState, 'open');
client.write('PING');
});

client.on('data', function(data) {
console.log(data);
assert.strictEqual('PONG', data);
assert.strictEqual('open', client.readyState);
assert.strictEqual(data, 'PONG');
assert.strictEqual(client.readyState, 'open');

setTimeout(function() {
assert.strictEqual('open', client.readyState);
assert.strictEqual(client.readyState, 'open');
if (count++ < N) {
client.write('PING');
} else {
Expand All @@ -97,7 +97,7 @@ function pingPongTest(port, host, on_complete) {

client.on('close', common.mustCall(function() {
console.log('client.end');
assert.strictEqual(N + 1, count);
assert.strictEqual(count, N + 1);
assert.ok(client_ended);
if (on_complete) on_complete();
}));
Expand Down