Skip to content

Profile on start #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 4 commits into from
Closed

Profile on start #2354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c3e417
add cpu-profile flag
bmeck Aug 10, 2015
1660a7d
move cpu profile location due to handle scope
bmeck Aug 10, 2015
600ac74
add --profile-cpu command line flag
bmeck Aug 11, 2015
4343fdf
remove unsued char*, better docs on --profile-cpu
bmeck Aug 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unsued char*, better docs on --profile-cpu
  • Loading branch information
@bmeck
bmeck committed Aug 12, 2015
commit 4343fdf4cc5eab87f1182c26ba856fca15187460
2 changes: 1 addition & 1 deletion doc/iojs.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ and servers.

--track-heap-objects track heap object allocations for heap snapshots

--profile-cpu begin cpu profiling during start up
--profile-cpu silently begin cpu profiler during start up

--v8-options print v8 command line options

Expand Down
6 changes: 3 additions & 3 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ static bool abort_on_uncaught_exception = false;
static bool trace_sync_io = false;
static bool track_heap_objects = false;
static bool profile_cpu = false;
static const char* profile_title = "";
static const char* eval_string = nullptr;
static unsigned int preload_module_count = 0;
static const char** preload_modules = nullptr;
Expand Down Expand Up @@ -3107,7 +3106,7 @@ static void PrintHelp() {
" is detected after the first tick\n"
" --track-heap-objects track heap object allocations for heap "
"snapshots\n"
" --profile-cpu being cpu profiling during start up\n"
" --profile-cpu silently begin cpu profiler during start up\n"
" --v8-options print v8 command line options\n"
#if defined(NODE_HAVE_I18N_SUPPORT)
" --icu-data-dir=dir set ICU data load path to dir\n"
Expand Down Expand Up @@ -3943,8 +3942,9 @@ static void StartNodeInstance(void* arg) {
Local<Context> context = Context::New(isolate);

// CpuProfiler requires HandleScope
// addons can pick up the results with StopProfiling(...) using same title
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Sep 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize and punctuate the comment.

if (profile_cpu) {
isolate->GetCpuProfiler()->StartProfiling(String::NewFromUtf8(isolate, profile_title), true);
isolate->GetCpuProfiler()->StartProfiling(String::Empty(isolate), true);
}

Environment* env = CreateEnvironment(isolate, context, instance_data);
Expand Down