Skip to content

test: fix argument order in assertions #23506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
riktothepast wants to merge 3 commits into from
Closed

test: fix argument order in assertions #23506

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a28070
test: fix argument order in assertions
Oct 12, 2018
116134f
test: Fixes argument order in assertion.
Oct 12, 2018
04ec319
Revert "test: Fixes argument order in assertion."
Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "test: Fixes argument order in assertion." 
This reverts commit 116134f.
  • Loading branch information
Illescas, Ricardo committed Oct 12, 2018
commit 04ec3198d6ff00bbb5de888100fc8b7bfd6f9604
2 changes: 1 addition & 1 deletion test/known_issues/test-http-path-contains-unicode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const http = require('http');

const expected = '/café🐶';

assert.strictEqual(expected, '/caf\u{e9}\u{1f436}');
assert.strictEqual('/caf\u{e9}\u{1f436}', expected);

const server = http.createServer(common.mustCall(function(req, res) {
assert.strictEqual(req.url, expected);
Expand Down