Skip to content

test: label the actual and expected value correctly in test-http-stat… #23490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fastereder wants to merge 2 commits into from
Closed

test: label the actual and expected value correctly in test-http-stat… #23490

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2425de
test: label the actual and expected value correctly in test-http-stat…
fastereder Oct 12, 2018
f371b60
doc: added info how to run single tests to BUILDING.md
fastereder Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: label the actual and expected value correctly in test-http-stat… 
…us-message.js

Fixed the order of the function parameters given to assert.strictEqual(). When there is an assertion error, the actual and expected value is labeled correctly.
  • Loading branch information
@fastereder
fastereder committed Oct 12, 2018
commit e2425de1bb0e2f1d1a6deaf603f48d921155170f
16 changes: 10 additions & 6 deletions test/parallel/test-http-status-message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,22 @@ const s = http.createServer(function(req, res) {

s.listen(0, test);


function test() {
const bufs = [];
const client = net.connect(this.address().port, function() {
client.write('GET / HTTP/1.1\r\nConnection: close\r\n\r\n');
});
const client = net.connect(
this.address().port,
function() {
client.write('GET / HTTP/1.1\r\nConnection: close\r\n\r\n');
}
);
client.on('data', function(chunk) {
bufs.push(chunk);
});
client.on('end', function() {
const head = Buffer.concat(bufs).toString('latin1').split('\r\n')[0];
assert.strictEqual('HTTP/1.1 200 Custom Message', head);
const head = Buffer.concat(bufs)
.toString('latin1')
.split('\r\n')[0];
assert.strictEqual(head, 'HTTP/1.1 200 Custom Message');
console.log('ok');
s.close();
});
Expand Down