Skip to content

Release Proposal: v3.1.0 #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fishrock123 merged 20 commits into from
Aug 19, 2015
Merged

Release Proposal: v3.1.0 #2347

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d1307b2
src: don't use fopen() in require() fast path
bnoordhuis Aug 13, 2015
844d3f0
path: use '===' instead of '==' for comparison
Aug 15, 2015
a3160c0
test: correct spelling of 'childProcess'
muddletoes Nov 12, 2014
b196c1d
src: fix memory leak in DLOpen
skomski Aug 14, 2015
f45487c
crypto: fix memory leak in SetDHParam
skomski Aug 14, 2015
a760a87
crypto: fix memory leak in SafeX509ExtPrint
skomski Aug 14, 2015
6a16368
crypto: fix memory leak in PublicKeyCipher::Cipher
skomski Aug 14, 2015
ba6eb8a
crypto: fix memory leak in ECDH::SetPrivateKey
skomski Aug 14, 2015
605f6ee
crypto: fix memory leak in PBKDF2Request
skomski Aug 14, 2015
fb0f5d7
tools: run the tick processor without building v8
Jul 1, 2015
cbb75c4
tls: fix throughput issues after incorrect merge
indutny Aug 14, 2015
7fe6dd8
crypto: check for OpenSSL errors when signing
pmq20 Aug 18, 2015
34f2cfa
src: better error message on failed Buffer malloc
skomski Aug 17, 2015
850c794
test: refactor test-fs-watchfile.js
Trott Aug 15, 2015
6483bc2
doc: clarify options for fs.watchFile()
Trott Aug 18, 2015
46cdb2f
test: lint addon tests
bnoordhuis Aug 18, 2015
194eeb8
test: drop Isolate::GetCurrent() from addon tests
bnoordhuis Aug 18, 2015
2ff183d
Update FIPS instructions in README.md
mhdawson Jul 30, 2015
53596fd
2015-08-18 io.js v3.1.0 Release
Fishrock123 Aug 18, 2015
8576324
Working on v3.1.1
Fishrock123 Aug 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: fix memory leak in DLOpen 
PR-URL: #2375
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@skomski @Fishrock123
skomski authored and Fishrock123 committed Aug 19, 2015
commit b196c1da3c36c426009aa5d78c2356f79b09ce90
5 changes: 5 additions & 0 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2124,6 +2124,7 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {

if (is_dlopen_error) {
Local<String> errmsg = OneByteString(env->isolate(), uv_dlerror(&lib));
uv_dlclose(&lib);
#ifdef _WIN32
// Windows needs to add the filename into the error message
errmsg = String::Concat(errmsg, args[1]->ToString(env->isolate()));
Expand All @@ -2133,10 +2134,12 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
}

if (mp == nullptr) {
uv_dlclose(&lib);
env->ThrowError("Module did not self-register.");
return;
}
if (mp->nm_version != NODE_MODULE_VERSION) {
uv_dlclose(&lib);
char errmsg[1024];
snprintf(errmsg,
sizeof(errmsg),
Expand All @@ -2146,6 +2149,7 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
return;
}
if (mp->nm_flags & NM_F_BUILTIN) {
uv_dlclose(&lib);
env->ThrowError("Built-in module self-registered.");
return;
}
Expand All @@ -2162,6 +2166,7 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
} else if (mp->nm_register_func != nullptr) {
mp->nm_register_func(exports, module, mp->nm_priv);
} else {
uv_dlclose(&lib);
env->ThrowError("Module has no declared entry point.");
return;
}
Expand Down