Skip to content

test: make sure assert.strictEqual arguments are consistent #23457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andy-ganchrow wants to merge 1 commit into from
Closed

test: make sure assert.strictEqual arguments are consistent #23457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: make sure assert.strictEqual arguments are consistent with docu… 
…mentation
  • Loading branch information
@andy-ganchrow
andy-ganchrow committed Oct 12, 2018
commit 004ff3effe70f72071e988ea895067469572e8d3
12 changes: 6 additions & 6 deletions test/parallel/test-vm-new-script-new-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ const Script = require('vm').Script;
const script = new Script('\'passed\';');
const result1 = script.runInNewContext();
const result2 = script.runInNewContext();
assert.strictEqual('passed', result1);
assert.strictEqual('passed', result2);
assert.strictEqual(result1, 'passed');
assert.strictEqual(result2, 'passed');
}

{
Expand All @@ -52,7 +52,7 @@ const Script = require('vm').Script;
global.hello = 5;
const script = new Script('hello = 2');
script.runInNewContext();
assert.strictEqual(5, global.hello);
assert.strictEqual(global.hello, 5);

// Cleanup
delete global.hello;
Expand All @@ -68,9 +68,9 @@ const Script = require('vm').Script;
/* eslint-disable no-unused-vars */
const baz = script.runInNewContext(global.obj);
/* eslint-enable no-unused-vars */
assert.strictEqual(1, global.obj.foo);
assert.strictEqual(2, global.obj.bar);
assert.strictEqual(2, global.foo);
assert.strictEqual(global.obj.foo, 1);
assert.strictEqual(global.obj.bar, 2);
assert.strictEqual(global.foo, 2);

// cleanup
delete global.code;
Expand Down