Skip to content

test: correct isReused parameter in test-http-parser #23412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
basti1302 wants to merge 1 commit into from
+2 −2
Closed

test: correct isReused parameter in test-http-parser #23412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: correct isReused parameter in test-http-parser 
Pass true for isReused in the two reinitialize calls to better reflect
the actual usage here.
  • Loading branch information
@basti1302
basti1302 committed Oct 10, 2018
commit b4c542f2b167a0b71c2a531f376028038952888d
4 changes: 2 additions & 2 deletions test/parallel/test-http-parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function expectBody(expected) {
throw new Error('hello world');
};

parser.reinitialize(HTTPParser.REQUEST, false);
parser.reinitialize(HTTPParser.REQUEST, true);

assert.throws(
() => { parser.execute(request, 0, request.length); },
Expand Down Expand Up @@ -558,7 +558,7 @@ function expectBody(expected) {
parser[kOnBody] = expectBody('ping');
parser.execute(req1, 0, req1.length);

parser.reinitialize(REQUEST, false);
parser.reinitialize(REQUEST, true);
parser[kOnBody] = expectBody('pong');
parser[kOnHeadersComplete] = onHeadersComplete2;
parser.execute(req2, 0, req2.length);
Expand Down