Skip to content

test: refactor common.ddCommand() #23411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 6 commits into from
Closed

test: refactor common.ddCommand() #23411

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edf1a7c
test: refactor common.ddCommand()
Trott Oct 10, 2018
fd0eb95
fixup! test: refactor common.ddCommand()
Trott Oct 10, 2018
74bc7df
fixup! fixup! test: refactor common.ddCommand()
Trott Oct 10, 2018
d3d2bab
test: rename common.ddCommand()
Trott Oct 10, 2018
bf4f33c
fixup! fixup! fixup! test: refactor common.ddCommand()
Trott Oct 10, 2018
c1f684d
fixup! in module loader
refack Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: rename common.ddCommand() 
Change common.ddCommand() to common.createZeroFilledFile().
  • Loading branch information
@Trott
Trott committed Oct 10, 2018
commit d3d2bab5aafa413a9df6bbcfee30ae222406f58f
2 changes: 1 addition & 1 deletion test/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ symlinks
([SeCreateSymbolicLinkPrivilege](https://msdn.microsoft.com/en-us/library/windows/desktop/bb530716(v=vs.85).aspx)).
On non-Windows platforms, this always returns `true`.

### ddCommand(filename)
### createZeroFilledFile(filename)

Creates a 10 MB file of all null characters.

Expand Down
4 changes: 2 additions & 2 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ function childShouldThrowAndAbort() {
});
}

function ddCommand(filename) {
function createZeroFilledFile(filename) {
const fd = fs.openSync(filename, 'w');
fs.ftruncateSync(fd, 10240 * 1024);
Copy link
Copy Markdown
Member

@richardlau richardlau Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should either be 10 * 1024 * 1024 (my preference) or 10485760.

fs.closeSync(fd);
Expand Down Expand Up @@ -697,7 +697,7 @@ module.exports = {
busyLoop,
canCreateSymLink,
childShouldThrowAndAbort,
ddCommand,
createZeroFilledFile,
disableCrashOnUnhandledRejection,
enoughTestCpu,
enoughTestMem,
Expand Down
4 changes: 2 additions & 2 deletions test/common/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const {
PIPE,
hasIPv6,
childShouldThrowAndAbort,
ddCommand,
createZeroFilledFile,
platformTimeout,
allowGlobals,
mustCall,
Expand Down Expand Up @@ -71,7 +71,7 @@ export {
PIPE,
hasIPv6,
childShouldThrowAndAbort,
ddCommand,
createZeroFilledFile,
platformTimeout,
allowGlobals,
mustCall,
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http-chunk-problem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function executeRequest(cb) {

tmpdir.refresh();

common.ddCommand(filename);
common.createZeroFilledFile(filename);

server = http.createServer(function(req, res) {
res.writeHead(200);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-pipe-file-to-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const server = http.createServer(function(req, res) {
server.listen(0);

server.on('listening', function() {
common.ddCommand(filename);
common.createZeroFilledFile(filename);
makeRequest();
});

Expand Down