Skip to content

test: move some gc tests back to parallel/, unmark flaky #23356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

test: move some gc tests back to parallel/, unmark flaky #23356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: move some gc tests back to parallel/, unmark flaky 
These should no longer be flaky after the libuv update.

Refs: #23336
  • Loading branch information
@addaleax
addaleax committed Oct 12, 2018
commit 2d847d273970f5087d7760de728199c8d5b4e922
0 ...ential/test-gc-http-client-connaborted.js → ...rallel/test-gc-http-client-connaborted.js
View file
Open in desktop
File renamed without changes.
0 ...sequential/test-gc-http-client-onerror.js → test/parallel/test-gc-http-client-onerror.js
View file
Open in desktop
File renamed without changes.
0 ...sequential/test-gc-http-client-timeout.js → test/parallel/test-gc-http-client-timeout.js
View file
Open in desktop
File renamed without changes.
0 test/sequential/test-gc-net-timeout.js → test/parallel/test-gc-net-timeout.js
View file
Open in desktop
File renamed without changes.
11 changes: 0 additions & 11 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,8 @@ prefix sequential
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
# This test will be flaky until https://github.com/libuv/libuv/pull/1742 lands
# on Node.js.
test-fs-readfile-tostring-fail: PASS, FLAKY
# https://github.com/nodejs/node/issues/23066
test-gc-http-client-timeout: PASS, FLAKY
# https://github.com/nodejs/node/issues/22336
test-gc-http-client: PASS,FLAKY
# https://github.com/nodejs/node/issues/23067
test-gc-net-timeout: PASS,FLAKY
# https://github.com/nodejs/node/issues/23089
test-gc-http-client-onerror: PASS,FLAKY
# https://github.com/nodejs/node/issues/23219
test-gc-http-client-connaborted: PASS,FLAKY

[$system==win32]
# https://github.com/nodejs/node/issues/22327
Expand Down