Skip to content

add WPT Console tests #23340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

add WPT Console tests #23340

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
482ee10
test: rename WPT console test
Trott Oct 8, 2018
9c00fd0
test: add WPT console-label-conversion test
Trott Oct 8, 2018
168566d
test: separate WPT console test from other test
Trott Oct 8, 2018
d02063b
test: add WPT console-tests-historical
Trott Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add WPT console-label-conversion test 
Add console-label-conversion.any.js from WPT to the test suite.
  • Loading branch information
@Trott
Trott committed Oct 9, 2018
commit 9c00fd01f4810273f36c7fc910a0a214915fcd1f
45 changes: 45 additions & 0 deletions test/parallel/test-whatwg-console-label-conversion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
'use strict';

require('../common');

const { test, assert_true, assert_throws } =
require('../common/wpt');

/* eslint-disable max-len, object-curly-spacing */

/* The following tests should not be modified as they are copied */
/* WPT Refs:
https://github.com/web-platform-tests/wpt/blob/6f0a96ed650935b17b6e5d277889cfbe0ccc103e/console/console-label-conversion.any.js
License: hhttps://github.com/web-platform-tests/wpt/blob/6f0a96ed650935b17b6e5d277889cfbe0ccc103e/LICENSE.md
Comment thread
Trott marked this conversation as resolved.
Outdated
*/

// https://console.spec.whatwg/org/#counting
// https://console.spec.whatwg/org/#timing

const methods = ['count', 'countReset', 'time', 'timeLog', 'timeEnd'];

for (const method of methods) {
test(() => {
let labelToStringCalled = false;

console[method]({
toString() {
labelToStringCalled = true;
}
});

assert_true(labelToStringCalled, `${method}() must call toString() on label when label is an object`);
}, `console.${method}()'s label gets converted to string via label.toString() when label is an object`);

test(() => {
assert_throws({name: 'Error'}, () => {
console[method]({
toString() {
throw new Error('conversion error');
}
});
}, `${method} must re-throw any exceptions thrown by label.toString() conversion`);
}, `console.${method}() throws exceptions generated by erroneous label.toString() conversion`);
}

/* eslint-enable */