Skip to content

net: use connect() instead of connect.call() #23289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JacksonTian wants to merge 1 commit into from
Closed

net: use connect() instead of connect.call() #23289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
net: use connect() instead of connect.call() 
Use socket.connect() directly.
  • Loading branch information
@JacksonTian
JacksonTian committed Oct 6, 2018
commit 56857a112a8f03da409d13337f279c2c90da64aa
2 changes: 1 addition & 1 deletion lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ function connect(...args) {
socket.setTimeout(options.timeout);
}

return Socket.prototype.connect.call(socket, normalized);
return socket.connect(normalized);
}


Expand Down