Skip to content

N-API SharedArrayBuffer api #23279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orange4glace wants to merge 7 commits into from
Closed

N-API SharedArrayBuffer api #23279

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cbaf295
N-API SharedArrayBuffer api
orange4glace Oct 5, 2018
9bc56ed
N-API SharedArrayBuffer api
orange4glace Oct 5, 2018
c308106
[api] Add : SharedArrayBuffer Experimental API
orange4glace Nov 18, 2018
fae1c8e
[api] Add : SharedArrayBuffer Experimental API
orange4glace Nov 18, 2018
a14869a
[api] deleted : duplicated declarations
orange4glace Nov 18, 2018
9965e78
[api] fixed : type error
orange4glace Nov 18, 2018
2d96cc2
[api] fixed: typo
orange4glace Nov 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
N-API SharedArrayBuffer api
  • Loading branch information
@orange4glace
orange4glace committed Oct 5, 2018
commit 9bc56ed53ef97660c6f761ab53eccfcbbee5956b
2 changes: 1 addition & 1 deletion src/node_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3640,7 +3640,7 @@ napi_status napi_get_sharedarraybuffer_info(napi_env env,
CHECK_ARG(env, arraybuffer);

v8::Local<v8::Value> value = v8impl::V8LocalValueFromJsValue(arraybuffer);
RETURN_STATUS_IF_FALSE(env, value->IsArrayBuffer(), napi_invalid_arg);
RETURN_STATUS_IF_FALSE(env, value->IsSharedArrayBuffer(), napi_invalid_arg);

v8::ArrayBuffer::Contents contents =
value.As<v8::SharedArrayBuffer>()->GetContents();
Expand Down