Skip to content

src: add missing virtual destructors #23215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 3 commits into from
Closed

src: add missing virtual destructors #23215

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68e5373
src: add virtual desctructor to Options class
danbev Oct 2, 2018
0384ab7
crypto: add virtual dtor to KeyPairGenerationConfig
danbev Oct 2, 2018
cbda824
inspector: add virtual destructor to WorkerDelegate
danbev Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
crypto: add virtual dtor to KeyPairGenerationConfig 
Currently the KeyPairGenerationConfigs class has a virtual function
but no virtual destructor which means that if delete is called on a
KeyPairGenerationConfig pointer to a derived instance, the derived
destructor will not get called.

The following warning is currently being printed when
compiling:

warning: delete called on 'node::crypto::KeyPairGenerationConfig' that
is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor]
    delete __ptr;

This commit adds a virtual destructor.
  • Loading branch information
@danbev
danbev committed Oct 2, 2018
commit 0384ab7e683cc7b6b9f20e40835e20ed189c5827
1 change: 1 addition & 0 deletions src/node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4839,6 +4839,7 @@ class KeyPairGenerationConfig {
virtual bool Configure(const EVPKeyCtxPointer& ctx) {
return true;
}
virtual ~KeyPairGenerationConfig() {}
};

class RSAKeyPairGenerationConfig : public KeyPairGenerationConfig {
Expand Down