Skip to content

deps: provide more V8 backwards compatibility #23158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
+178 −16
Closed

deps: provide more V8 backwards compatibility #23158

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e3204f
deps: patch V8 to 7.0.276.24
targos Oct 2, 2018
a0fb221
deps: revert 9136dd8088a9 from upstream V8
addaleax Oct 4, 2018
7a0dd5b
deps: provide more V8 backwards compatibility
addaleax Sep 29, 2018
cf7bb97
fixup! deps: provide more V8 backwards compatibility
addaleax Oct 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! deps: provide more V8 backwards compatibility
  • Loading branch information
@addaleax
addaleax committed Oct 5, 2018
commit cf7bb9707228241aa876281ce54f2c9f949b5e40
4 changes: 2 additions & 2 deletions deps/v8/src/api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3890,13 +3890,13 @@ void v8::RegExp::CheckCast(v8::Value* that) {

bool Value::BooleanValue() const {
return BooleanValue(Isolate::GetCurrent()->GetCurrentContext())
.FromMaybe(false);
.FromJust();
}


double Value::NumberValue() const {
return NumberValue(Isolate::GetCurrent()->GetCurrentContext())
.FromMaybe(0.0);
.FromMaybe(std::numeric_limits<double>::quiet_NaN());
}


Expand Down