Skip to content

doc: formalize non-const reference usage in C++ style guide #23155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

doc: formalize non-const reference usage in C++ style guide #23155

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73139a5
doc: formalize non-const reference usage in C++ style guide
addaleax Sep 22, 2018
8daa18e
squash! doc: formalize non-const reference usage in C++ style guide
addaleax Oct 1, 2018
e9f8406
fixup! squash! doc: formalize non-const reference usage in C++ style …
addaleax Oct 1, 2018
acba30d
fixup! fixup! squash! doc: formalize non-const reference usage in C++…
addaleax Oct 2, 2018
04f941a
fixup! fixup! fixup! squash! doc: formalize non-const reference usage…
addaleax Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! squash! doc: formalize non-const reference usage in C++… 
… style guide
  • Loading branch information
@addaleax
addaleax committed Oct 2, 2018
commit acba30df49557b5dc101b49b1d9f65703508d7ca
4 changes: 2 additions & 2 deletions CPP_STYLE_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ class ExampleClass {

private:
std::string foo_string_;
// Pointer instead of reference. If this objects 'owns' the other object,
// this should be be a `std::unique_ptr<OtherClass>`; a
// Pointer instead of reference. If this object 'owns' the other object,
// this should be a `std::unique_ptr<OtherClass>`; a
// `std::shared_ptr<OtherClass>` can also be a better choice.
OtherClass* pointer_to_other_;
};
Expand Down