Skip to content

test-child-process-disconnected.js added more descriptive error message to test's assert #23118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Josh-Broomfield wants to merge 3 commits into from
Closed

test-child-process-disconnected.js added more descriptive error message to test's assert #23118

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be44f96
Added more descriptive error message to test's assert
Josh-Broomfield Sep 27, 2018
c563cb6
removed trailing space
Josh-Broomfield Sep 27, 2018
56d25ea
removed unnecessary type property
Josh-Broomfield Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added more descriptive error message to test's assert
  • Loading branch information
@Josh-Broomfield
Josh-Broomfield committed Sep 27, 2018
commit be44f96a4e5520fda3126cbb8afa07aed9df026e
7 changes: 6 additions & 1 deletion test/parallel/test-child-process-disconnect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,12 @@ if (process.argv[2] === 'child') {
// ready to be disconnected
if (data === 'ready') {
child.disconnect();
assert.throws(child.disconnect.bind(child), Error);
assert.throws(
child.disconnect.bind(child),
{
code: 'ERR_IPC_DISCONNECTED',
type: Error
});
return;
}

Expand Down