Skip to content

test: fix flaky sequential/test-fs-watch-system-limit #23038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

test: fix flaky sequential/test-fs-watch-system-limit #23038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky sequential/test-fs-watch-system-limit 
This test has at least once locally received `EMFILE` rather
than `ENOSPC`, which also seems to provide a reasonable error
message (which is what the test ultimately checks).
  • Loading branch information
@addaleax
addaleax committed Sep 23, 2018
commit d1f9af444942276027bac8d932797d4ef4b291f0
3 changes: 2 additions & 1 deletion test/sequential/test-fs-watch-system-limit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ gatherStderr.on('data', common.mustCallAtLeast((chunk) => {
if (accumulated.includes('Error:') && !finished) {
assert(
accumulated.includes('ENOSPC: System limit for number ' +
'of file watchers reached'),
'of file watchers reached') ||
accumulated.includes('EMFILE: '),
accumulated);
console.log(`done after ${processes.length} processes, cleaning up`);
finished = true;
Expand Down