Skip to content

test: modernize JS in some test-fs-*.js #23031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jy95 wants to merge 13 commits into from
Closed

test: modernize JS in some test-fs-*.js #23031

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b3adea2
test: use ES2017 syntax in test-fs-access
jy95 Sep 22, 2018
c91bacd
test: use ES2017 syntax in test-fs-append-file-sync
jy95 Sep 22, 2018
a8826dc
test: use ES2017 syntax in test-fs-copyfile
jy95 Sep 22, 2018
3b3f2bf
test: use ES2017 syntax in test-fs-open-flags
jy95 Sep 22, 2018
52efdf3
test: use ES2017 syntax in test-fs-open-mask
jy95 Sep 22, 2018
90d5f02
test: updated syntax in test-fs-stat-bigint
jy95 Sep 22, 2018
1721b43
test: fix missing typeof in test-fs-access
jy95 Sep 22, 2018
29ba8b5
test: remove .map variable for initialization variables
jy95 Sep 23, 2018
be96501
test: remove whitespace
jy95 Sep 23, 2018
f45ead2
test: separate lines
jy95 Sep 23, 2018
3b9a133
test: reset test-fs-append-file-sync to previous version
jy95 Sep 23, 2018
7e2ee7b
test: revert assertion changes
jy95 Sep 25, 2018
7f6555e
test: revert changes in test-fs-stat-bigint.js
jy95 Nov 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: updated syntax in test-fs-stat-bigint
  • Loading branch information
@jy95
jy95 committed Sep 22, 2018
commit 90d5f02c29b8456bac32186fba58d16fe3490ae3
32 changes: 4 additions & 28 deletions test/parallel/test-fs-stat-bigint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,34 +30,10 @@ function verifyStats(bigintStats, numStats) {
`Number version ${time}, BigInt version ${time2}n`);
} else if (key === 'mode') {
assert.strictEqual(bigintStats[key], BigInt(val));
assert.strictEqual(
bigintStats.isBlockDevice(),
numStats.isBlockDevice()
);
assert.strictEqual(
bigintStats.isCharacterDevice(),
numStats.isCharacterDevice()
);
assert.strictEqual(
bigintStats.isDirectory(),
numStats.isDirectory()
);
assert.strictEqual(
bigintStats.isFIFO(),
numStats.isFIFO()
);
assert.strictEqual(
bigintStats.isFile(),
numStats.isFile()
);
assert.strictEqual(
bigintStats.isSocket(),
numStats.isSocket()
);
assert.strictEqual(
bigintStats.isSymbolicLink(),
numStats.isSymbolicLink()
);
['isBlockDevice', 'isCharacterDevice', 'isDirectory', 'isFIFO', 'isFile',
Copy link
Copy Markdown
Member

@devsnek devsnek Sep 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate lines

Copy link
Copy Markdown
Contributor Author

@jy95 jy95 Sep 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean one line for each item of the array ? Sure if you want

'isFile', 'isSocket', 'isSymbolicLink' ].forEach(
(fct) => assert.strictEqual(bigintStats[fct](), numStats[fct]()));

} else if (common.isWindows && (key === 'blksize' || key === 'blocks')) {
assert.strictEqual(bigintStats[key], undefined);
assert.strictEqual(numStats[key], undefined);
Expand Down