Skip to content

crypto: remove unnecessary usage of goto #23018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 1 commit into from
Closed

crypto: remove unnecessary usage of goto #23018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
crypto: remove unnecessary usage of goto 
The control flow can easily be refactored to use break instead of
goto.
  • Loading branch information
@tniessen
tniessen committed Sep 22, 2018
commit ac1114b7644ab0f4b1001e968ac38d6c32f83862
4 changes: 1 addition & 3 deletions src/node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ int SSL_CTX_use_certificate_chain(SSL_CTX* ctx,
if (!r) {
ret = 0;
issuer = nullptr;
goto end;
break;
}
// Note that we must not free r if it was successfully
// added to the chain (while we must free the main
Expand All @@ -617,12 +617,10 @@ int SSL_CTX_use_certificate_chain(SSL_CTX* ctx,
issuer = X509_dup(issuer);
if (issuer == nullptr) {
ret = 0;
goto end;
}
}
}

end:
issuer_->reset(issuer);

if (ret && x != nullptr) {
Expand Down