Skip to content

[canary] GYP v8 embedded builtins #22920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 7 commits into from
Closed

[canary] GYP v8 embedded builtins #22920

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85d9b7d
deps: update V8 to 7.1.163
targos Sep 22, 2018
aefa8bf
build: reset embedder string to "-node.0"
targos Sep 22, 2018
f6ff7a9
src: update NODE_MODULE_VERSION to 68
targos Sep 22, 2018
e366bc6
deps: update v8.gyp
targos Aug 29, 2018
720c2b5
deps: V8 sync gypfiles with 7.1
refack Oct 4, 2018
b65f4d2
temprary fix for CI
refack Oct 2, 2018
311fd7f
fixup! set V8 variables
refack Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! set V8 variables
  • Loading branch information
@refack
refack committed Oct 4, 2018
commit 311fd7f048ccd6fbf50d2c59395111de8a7b4b31
22 changes: 11 additions & 11 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,40 +40,40 @@
##### V8 defaults for Node.js #####

# Old time default, now explicitly stated.
'v8_use_snapshot%': 'true',
'v8_use_snapshot': 'true',

# Refs: https://github.com/nodejs/node/issues/23122
# Refs: https://github.com/nodejs/node/issues/23167
# Enable compiler warnings when using V8_DEPRECATED apis.
'v8_deprecation_warnings%': 1,
'v8_deprecation_warnings': 1,
# Enable compiler warnings when using V8_DEPRECATE_SOON apis.
'v8_imminent_deprecation_warnings%': 1,
'v8_imminent_deprecation_warnings': 1,

# Default to -O0 for debug builds.
'v8_optimized_debug%': 0,
'v8_optimized_debug': 0,

# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler%': 1,
'v8_enable_disassembler': 1,

# Don't bake anything extra into the snapshot.
'v8_use_external_startup_data%': 0,
'v8_use_external_startup_data': 0,

# https://github.com/nodejs/node/pull/22920/files#r222779926
'v8_enable_handle_zapping%': 0,
'v8_enable_handle_zapping': 0,

# Disable V8 untrusted code mitigations.
# See https://github.com/v8/v8/wiki/Untrusted-code-mitigations
'v8_untrusted_code_mitigations%': 'false',
'v8_untrusted_code_mitigations': 'false',

# Still WIP in V8 7.1
'v8_enable_pointer_compression%': 'false',
'v8_enable_pointer_compression': 'false',

# New in V8 7.1
'v8_enable_embedded_builtins%': 'true',
'v8_enable_embedded_builtins': 'true',

# This is more of a V8 dev setting
# https://github.com/nodejs/node/pull/22920/files#r222779926
'v8_enable_fast_mksnapshot%': 0,
'v8_enable_fast_mksnapshot': 0,

##### end V8 defaults #####

Expand Down