Skip to content

doc,test: fix default maxBuffer size #22894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koh110 wants to merge 3 commits into from
Closed

doc,test: fix default maxBuffer size #22894

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34d937d
doc: fix default maxBuffer size
koh110 Sep 17, 2018
f605ba9
fixup! doc: fix default maxBuffer size
sam-github Apr 3, 2019
e2a0521
fixup! doc: fix default maxBuffer size
sam-github Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! doc: fix default maxBuffer size
  • Loading branch information
@sam-github
sam-github committed Apr 3, 2019
commit f605ba946034e191b828de64534eb4d3b72ea1ab
4 changes: 2 additions & 2 deletions ...llel/test-child-process-exec-maxBuffer.js → ...arallel/test-child-process-exec-maxbuf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ function runChecks(err, stdio, streamName, expected) {

// default value
{
// eslint-disable-next-line max-len
const cmd = `${process.execPath} -e "console.log('a'.repeat(200 * 1024 - 1))"`;
const cmd =
`${process.execPath} -e "console.log('a'.repeat(200 * 1024 - 1))"`;

cp.exec(cmd, common.mustCall((err, stdout, stderr) => {
assert.ifError(err);
Expand Down
8 changes: 4 additions & 4 deletions .../test-child-process-execfile-maxBuffer.js → ...lel/test-child-process-execfile-maxbuf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function checkFactory(streamName) {
{
execFile(
process.execPath,
['-e', "console.log('a'.repeat(200 * 1024))"],
['-e', `console.log('a'.repeat(200 * 1024))`],
checkFactory('stdout')
);
}
Expand All @@ -24,7 +24,7 @@ function checkFactory(streamName) {
{
execFile(
process.execPath,
['-e', "console.log('a'.repeat(200 * 1024 - 1))"],
['-e', `console.log('a'.repeat(200 * 1024 - 1))`],
common.mustCall((err, stdout, stderr) => {
assert.ifError(err);
assert.strictEqual(stdout.trim(), 'a'.repeat(200 * 1024 - 1));
Expand All @@ -38,7 +38,7 @@ function checkFactory(streamName) {

execFile(
process.execPath,
['-e', "console.log('hello world');"],
['-e', `console.log('hello world');`],
options,
common.mustCall((err, stdout, stderr) => {
assert.ifError(err);
Expand All @@ -65,7 +65,7 @@ const unicode = '中文测试'; // length = 4, byte length = 12
{
execFile(
process.execPath,
['-e', `console.error('${unicode}');"`],
['-e', `console.error('${unicode}');`],
{ maxBuffer: 10 },
checkFactory('stderr')
);
Expand Down