Skip to content

test: remove unreachable code #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 3 commits into from
Closed

test: remove unreachable code #2289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
057126a
test: disallow unreachable code
targos Aug 20, 2015
249db38
test: remove unreachable code
targos Aug 2, 2015
bb0ced5
fixup: remove console.error
targos Aug 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: remove console.error
  • Loading branch information
@targos
targos committed Aug 20, 2015
commit bb0ced5cfc1bec9bb5e0cb6296f576fedcac8fd5
2 changes: 0 additions & 2 deletions test/message/throw_custom_error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,5 @@
var common = require('../common');
var assert = require('assert');

console.error('before');

// custom error throwing
throw ({ name: 'MyCustomError', message: 'This is a custom message' });
3 changes: 1 addition & 2 deletions test/message/throw_custom_error.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
before
*test*message*throw_custom_error.js:8
*test*message*throw_custom_error.js:6
throw ({ name: 'MyCustomError', message: 'This is a custom message' });
^
MyCustomError: This is a custom message
2 changes: 0 additions & 2 deletions test/message/throw_non_error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,5 @@
var common = require('../common');
var assert = require('assert');

console.error('before');

// custom error throwing
throw ({ foo: 'bar' });
3 changes: 1 addition & 2 deletions test/message/throw_non_error.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
before
*test*message*throw_non_error.js:8
*test*message*throw_non_error.js:6
throw ({ foo: 'bar' });
^
[object Object]