repl: fixing the test cases

nodejs · antsmartian · Nov 26, 2019 · Nov 27, 2019 · Nov 27, 2019 · Nov 27, 2019
commit 57105230df6c76f565977950ce6f97c25569c80c
diff --git a/lib/internal/readline/utils.js b/lib/internal/readline/utils.js
@@ -443,7 +443,7 @@ function appendPreview(result, cursorTo, clearScreenDown) {
   this.previewResult = `\u001b[90m // ${result}\u001b[39m`;
   const line = `${this._prompt}${this.line} //${result}`;
   const columns = this.output.columns;
-  const hasColors = this.output.hasColors();
+  const hasColors = this.output.hasColors ? this.output.hasColors() : false;
   const s = hasColors ?
     `${this._prompt}${this.line}${this.previewResult}` : line;
 

diff --git a/test/parallel/test-repl-persistent-history.js b/test/parallel/test-repl-persistent-history.js
@@ -92,7 +92,7 @@ const tests = [
     env: {},
     test: [UP, '\'42\'', ENTER],
     expected: [prompt, '\'', '4', '2', '\'',
-               '> \'42\'\u001b[90m // \'42\'\u001b[39m', '\'42\'\n',
+               '> \'42\' //\'42\'', '\'42\'\n',
                prompt, prompt],
     clean: false
   },

diff --git a/test/parallel/test-repl-preview-result.js b/test/parallel/test-repl-preview-result.js
@@ -82,7 +82,7 @@ const tests = [
            'aObj.a', CLEAR],
     expected: [
       wrapWithColorCode('aObj',
-                        '{ a: { b: { c: [ {}, \'test\' ] } } }'),
+                        '{ a: { b: { c: [Array] } } }'),
       wrapWithColorCode('aObj.a',
                         '{ b: { c: [ {}, \'test\' ] } }')]
   }
@@ -98,30 +98,32 @@ function runTest() {
   const env = opts.env;
   const test = opts.test;
   const expected = opts.expected;
+  const ouput = new stream.Writable({
+    write(chunk, _, next) {
+      const output = chunk.toString();
+
+      // Ignore everything except eval result
+      if (!output.includes('//')) {
+        return next();
+      }
+
+      const toBeAsserted = expected[0];
+      try {
+        assert.strictEqual(output, toBeAsserted);
+        expected.shift();
+      } catch (err) {
+        console.error(`Failed test # ${numtests - tests.length}`);
+        throw err;
+      }
+
+      next();
+    },
+  });
+  ouput.hasColors = () => true;
 
   REPL.createInternalRepl(env, {
     input: new ActionStream(),
-    output: new stream.Writable({
-      write(chunk, _, next) {
-        const output = chunk.toString();
-
-        // Ignore everything except eval result
-        if (!output.includes('//')) {
-          return next();
-        }
-
-        const toBeAsserted = expected[0];
-        try {
-          assert.strictEqual(output, toBeAsserted);
-          expected.shift();
-        } catch (err) {
-          console.error(`Failed test # ${numtests - tests.length}`);
-          throw err;
-        }
-
-        next();
-      }
-    }),
+    output: ouput,
     prompt: prompt,
     useColors: false,
     terminal: true

diff --git a/test/parallel/test-repl-programmatic-history.js b/test/parallel/test-repl-programmatic-history.js
@@ -90,7 +90,7 @@ const tests = [
     env: {},
     test: [UP, '\'42\'', ENTER],
     expected: [prompt, '\'', '4', '2', '\'',
-               `${prompt}'42'\u001b[90m // '42'\u001b[39m`,
+               `${prompt}'42' //'42'`,
                '\'42\'\n', prompt, prompt],
     clean: false
   },