Skip to content

tools: .eslintrc.js messages "default" typo style #22868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lovinglyy wants to merge 3 commits into from
Closed

tools: .eslintrc.js messages "default" typo style #22868

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
191c719
"Default" typo pattern for .eslintrc.js messages
lovinglyy Sep 14, 2018
030aa64
tools: .eslintrc.js messages "default" typo style
lovinglyy Sep 15, 2018
776c9ae
tools: .eslintrc.js messages "default" typo style
lovinglyy Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
"Default" typo pattern for .eslintrc.js messages 
* all methods and syntax keywords between backticks
* written numbers
  • Loading branch information
@lovinglyy
lovinglyy authored Sep 14, 2018
commit 191c7196f53099843c31bf45a26ae70923856c56
20 changes: 10 additions & 10 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,22 +128,22 @@ module.exports = {
{
object: 'assert',
property: 'deepEqual',
message: 'Use assert.deepStrictEqual().',
message: 'Use `assert.deepStrictEqual()`.',
},
{
object: 'assert',
property: 'notDeepEqual',
message: 'Use assert.notDeepStrictEqual().',
message: 'Use `assert.notDeepStrictEqual()`.',
},
{
object: 'assert',
property: 'equal',
message: 'Use assert.strictEqual() rather than assert.equal().',
message: 'Use `assert.strictEqual()` rather than `assert.equal()`.',
},
{
object: 'assert',
property: 'notEqual',
message: 'Use assert.notStrictEqual() rather than assert.notEqual().',
message: 'Use `assert.notStrictEqual()` rather than `assert.notEqual()`.',
},
{
property: '__defineGetter__',
Expand All @@ -164,27 +164,27 @@ module.exports = {
},
{
selector: "CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]",
message: 'assert.rejects() must be invoked with at least two arguments.',
message: '`assert.rejects()` must be invoked with at least two arguments.',
},
{
selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
message: 'Use an object as second argument of assert.throws()',
message: 'Use an object as second argument of `assert.throws()`',
},
{
selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]",
message: 'assert.throws() must be invoked with at least two arguments.',
message: '`assert.throws()` must be invoked with at least two arguments.',
},
{
selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]",
message: 'setTimeout() must be invoked with at least two arguments.',
message: '`setTimeout()` must be invoked with at least two arguments.',
},
{
selector: "CallExpression[callee.name='setInterval'][arguments.length<2]",
message: 'setInterval() must be invoked with at least 2 arguments.',
message: '`setInterval()` must be invoked with at least two arguments.',
},
{
selector: 'ThrowStatement > CallExpression[callee.name=/Error$/]',
message: 'Use new keyword when throwing an Error.',
message: 'Use `new` keyword when throwing an Error.',
Copy link
Copy Markdown
Member

@Trott Trott Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add backticks around Error as well?

Copy link
Copy Markdown
Contributor Author

@lovinglyy lovinglyy Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, it looks better in the sentence now

}
],
/* eslint-enable max-len */
Expand Down