Skip to content

[8.x] Backport http2 changes from 10.x #22850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kjin wants to merge 67 commits into from
Closed

[8.x] Backport http2 changes from 10.x #22850

Changes from 1 commit
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
141f166
http2: fix ping duration calculation
jasnell Apr 11, 2018
f3f4ee6
doc: close event does not take arguments
indranil Apr 14, 2018
ecc2a70
http2: refactor how trailers are done
jasnell Apr 11, 2018
8786251
test: remove message from strictEqual assertions
bryancr89 Apr 19, 2018
b01edd2
doc,http2: add parameters for Http2Session:connect event
ryzokuken Apr 21, 2018
19e41a6
test: add strictEqual method to assert
9christine Apr 21, 2018
ac14fec
doc: add parameters for Http2Session:error event
ryzokuken Apr 21, 2018
110ac58
doc: improve docs for Http2Session:frameError
ryzokuken Apr 23, 2018
df3e6d9
http: added aborted property to request
ronag Apr 17, 2018
4fbd216
test: removed assert.strictEqual message
kailashyogeshwar85 Apr 23, 2018
d0594df
doc: improve parameters for Http2Session:goaway event
ryzokuken Apr 26, 2018
7bb1a8c
http2: fix responses to long payload reqs
apapirovski Apr 16, 2018
cdbf96f
http2: fix ping callback
BridgeAR Apr 26, 2018
07aab18
test: verify arguments length in common.expectsError
BridgeAR Apr 26, 2018
c9865ff
doc: add parameters for settings events
ryzokuken Apr 27, 2018
d9efc87
http2: reduce require calls in http2/core
danbev Apr 30, 2018
ce96ad0
http2: rename http2_state class to Http2State
danbev Apr 30, 2018
807807f
doc: add parameters for Http2Session:stream event
ryzokuken May 5, 2018
7d23d63
test: fix flaky http2-flow-control test
apapirovski May 6, 2018
e3e16d7
doc: add params for ClientHttp2Session:altsvc
ryzokuken May 8, 2018
776c3d0
doc: add parameters for Http2Stream:error event
ryzokuken May 8, 2018
11f194f
http2: avoid bind and properly clean up in compat
ronag Apr 27, 2018
9cf40c5
test: improve reliability of http2-session-timeout
Trott May 11, 2018
2238e12
http2: fix end without read
apapirovski May 9, 2018
c9f8d6f
net,http2: refactor _write and _writev
ryzokuken May 9, 2018
4ef2393
doc: fix typo in http2.md
kakts May 20, 2018
2151bf3
http2: fix several serious bugs
apapirovski May 17, 2018
e825eed
test: fix flaky http2-session-unref
apapirovski May 21, 2018
830cc57
http2: delay closing stream
apapirovski May 28, 2018
21f3e27
http2: force through RST_STREAM in destroy
apapirovski May 29, 2018
b53a753
test: minor adjustments to test-http2-respond-file
addaleax Jun 2, 2018
3a34ebd
http2: fix premature destroy
apapirovski May 31, 2018
3d38b99
http2: safer Http2Session destructor
apapirovski Jun 6, 2018
4d46e35
http2: fix memory leak for uncommon headers
addaleax Jun 15, 2018
78c7fc4
http2: fix memory leak when headers are not emitted
addaleax Jun 16, 2018
f8ca564
http2: track memory allocated by nghttp2
addaleax Jun 14, 2018
9e64f91
doc: Improve doc for Http2 headers object
Flarna Jun 12, 2018
6bdee91
http2: pass incoming set-cookie header as array
Flarna Jun 15, 2018
00002a6
doc: fix http2stream.pushStream error doc
ChALkeR Jun 23, 2018
823b31e
http2: order declarations in core.js
Trott Jul 6, 2018
a9053fa
errors: fix undefined HTTP2 and tls errors
thatshailesh Jun 27, 2018
9a0d117
http2: remove `waitTrailers` listener after closing a stream
RidgeA Jul 11, 2018
41edcf4
doc: add missing `require` to example in http2.md
kevinsimper Jul 17, 2018
d78a7b3
http2: remove unused nghttp2 error list
addaleax Jul 15, 2018
aa4c19b
http2: release request()'s "connect" event listener after it runs
ide Jul 21, 2018
833ef17
test: refactor test-http2-compat-serverresponse-finished.js
antsmartian Jul 28, 2018
23b53e7
test: improve reliability in http2-session-timeout
Trott Jul 30, 2018
07ef45d
http2: remove `streamError` from docs
jasnell Aug 10, 2018
411acb7
doc: clarify http2 docs around class exports
jasnell Aug 10, 2018
ee3e471
http2: avoid race condition in OnHeaderCallback
jasnell Aug 10, 2018
81f3ebc
test: add test-http2-large-file sequential test
jasnell Aug 10, 2018
f1e310e
http2: explicitly disallow nested push streams
jasnell Aug 10, 2018
3dc84ca
http2: emit timeout on compat request and response
jasnell Aug 10, 2018
28cd408
doc: make createPushResponse() more detailled
Aug 17, 2018
391e30a
doc: simplify http2 wording and formatting
Trott Aug 26, 2018
3640568
http2: throw better error when accessing unbound socket proxy
jasnell Aug 23, 2018
f6d9bf3
deps: update to nghttp2 1.33.0
addaleax Sep 2, 2018
62ce017
http2: don't expose the original socket through the socket proxy
szmarczak Sep 2, 2018
f9cd2d5
doc: document http2 timeouts
sagitsofan Sep 10, 2018
565d9d8
http2: add http2stream.endAfterHeaders property
jasnell Sep 13, 2018
2fd285a
http2: check if stream is not destroyed before sending trailers
mcollina Sep 17, 2018
bdaccc9
http2: add origin frame support
jasnell Sep 17, 2018
48d8766
http2: do not falsely emit 'aborted' on push
apapirovski Sep 15, 2018
40a8814
http2: add ping event
jasnell Sep 21, 2018
593f8d9
test: remove setImmediate from timeout test
Trott Sep 24, 2018
4f46d4b
test: improve debugging information for http2 test
Trott Sep 24, 2018
19e925b
http2: graduate from experimental
jasnell Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http2: fix ping duration calculation 
PR-URL: #19956
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
@jasnell @kjin
jasnell authored and kjin committed Oct 16, 2018
commit 141f166bda5b2b54c718a5cf5ecd5c996a2ee7b2
4 changes: 2 additions & 2 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2832,8 +2832,8 @@ void Http2Session::Http2Ping::Send(uint8_t* payload) {
}

void Http2Session::Http2Ping::Done(bool ack, const uint8_t* payload) {
session_->statistics_.ping_rtt = (uv_hrtime() - startTime_);
double duration = (session_->statistics_.ping_rtt - startTime_) / 1e6;
session_->statistics_.ping_rtt = uv_hrtime() - startTime_;
double duration = session_->statistics_.ping_rtt / 1e6;

Local<Value> buf = Undefined(env()->isolate());
if (payload != nullptr) {
Expand Down