Skip to content

zlib: fix memory leak for invalid input #22713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

zlib: fix memory leak for invalid input #22713

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2be5eb6
zlib: fix memory leak for invalid input
addaleax Sep 5, 2018
705fb2b
fixup! zlib: fix memory leak for invalid input
addaleax Sep 5, 2018
68d9798
fixup! zlib: fix memory leak for invalid input
addaleax Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! zlib: fix memory leak for invalid input
  • Loading branch information
@addaleax
addaleax committed Sep 5, 2018
commit 705fb2bb3e48f863d82b3f843a795ccc179726a5
7 changes: 4 additions & 3 deletions test/parallel/test-zlib-invalid-input-memory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ const ongc = common.mustCall();
const input = Buffer.from('foobar');
const strm = zlib.createInflate();
strm.end(input);
strm.once('error', common.mustCall((err) => assert(err)));
strm.once('error', common.mustCall((err) => {
assert(err);
setImmediate(global.gc);
}));
onGC(strm, { ongc });
}

setImmediate(() => global.gc());