Skip to content

Remove /MP from default additonal options #22661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skelliam wants to merge 3 commits into from
Closed

Remove /MP from default additonal options #22661

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
055153e
Remove /MP from default additonal options
skelliam Sep 2, 2018
10a5c16
Remove another instance of /MP
skelliam Sep 2, 2018
41afa8e
Add MultiProcessorCompilation = True
skelliam Sep 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add MultiProcessorCompilation = True 
this will replace the hardcoded /MP with an implicit /MP that is easier for users to override.
  • Loading branch information
@skelliam
skelliam authored Sep 3, 2018
commit 41afa8ed255ef0dd6e8ec251df16de036073efec
2 changes: 2 additions & 0 deletions common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@
'MinimalRebuild': 'false',
'OmitFramePointers': 'false',
'BasicRuntimeChecks': 3, # /RTC1
'MultiProcessorCompilation': 'true',
'AdditionalOptions': [
'/bigobj', # prevent error C1128 in VS2015
],
Expand Down Expand Up @@ -244,6 +245,7 @@
'EnableFunctionLevelLinking': 'true',
'EnableIntrinsicFunctions': 'true',
'RuntimeTypeInfo': 'false',
'MultiProcessorCompilation': 'true',
'AdditionalOptions': [
],
}
Expand Down