Skip to content

worker: display MessagePort status in util.inspect() #22658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 6 commits into from
Closed

worker: display MessagePort status in util.inspect() #22658

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16f78ff
worker: display MessagePort status in util.inspect()
addaleax Sep 2, 2018
257228c
test: fix flaky test-worker-message-port-transfer-self
addaleax Sep 2, 2018
1556ba5
fixup! worker: display MessagePort status in util.inspect()
addaleax Sep 2, 2018
e394fb3
fixup! test: fix flaky test-worker-message-port-transfer-self
addaleax Sep 2, 2018
fb70a36
fixup! worker: display MessagePort status in util.inspect()
addaleax Sep 2, 2018
1db359c
fixup! test: fix flaky test-worker-message-port-transfer-self
addaleax Sep 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! test: fix flaky test-worker-message-port-transfer-self
  • Loading branch information
@addaleax
addaleax committed Sep 2, 2018
commit e394fb37b3f3bb200359e6a85ce3fa07a8cb98d5
2 changes: 1 addition & 1 deletion test/parallel/test-worker-message-port-transfer-self.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ port1.postMessage(2);

function tick(n, cb) {
if (--n > 0)
Copy link
Copy Markdown
Member

@lundibundi lundibundi Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually makes half-the-n ticks, was this intentional?

Copy link
Copy Markdown
Member Author

@addaleax addaleax Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Thanks for catching!

return setImmediate(() => tick(n-1, cb));
return setImmediate(() => tick(n - 1, cb));
Copy link
Copy Markdown
Member

@lundibundi lundibundi Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is return needed here?

Copy link
Copy Markdown
Member Author

@addaleax addaleax Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, removed it :)

else
cb();
}