Skip to content

process: generate list of allowed env flags programmatically #22638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

process: generate list of allowed env flags programmatically #22638

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aec3668
process: generate list of allowed env flags programmatically
addaleax Aug 31, 2018
f05091c
fixup! process: generate list of allowed env flags programmatically
addaleax Sep 2, 2018
0002b1e
lib: generate allowedNodeEnvironmentFlags lazily
addaleax Aug 31, 2018
1f37916
fixup! process: generate list of allowed env flags programmatically
addaleax Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! process: generate list of allowed env flags programmatically
  • Loading branch information
@addaleax
addaleax committed Sep 5, 2018
commit 1f37916ad3d6e70aa0e5ca1e398ec8fa20a64ede
9 changes: 5 additions & 4 deletions test/parallel/test-process-env-allowed-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ require('../common');
// assert legit flags are allowed, and bogus flags are disallowed
{
const goodFlags = [
'--inspect-brk',
'inspect-brk',
'--perf_basic_prof',
'--perf-basic-prof',
'perf-basic-prof',
Expand All @@ -17,8 +15,11 @@ require('../common');
'-r',
'r',
'--stack-trace-limit=100',
'--stack-trace-limit=-=xX_nodejs_Xx=-'
];
'--stack-trace-limit=-=xX_nodejs_Xx=-',
].concat(process.config.variables.v8_enable_inspector ? [
'--inspect-brk',
'inspect-brk',
] : []);

const badFlags = [
'--inspect_brk',
Expand Down