Skip to content

test: check parameter type of fs.mkdir() #22616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shisama wants to merge 4 commits into from
+60 −0
Closed

test: check parameter type of fs.mkdir() #22616

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6cb82ab
test: check parameter type of fs.mkdir()
Aug 30, 2018
df5ee0f
test: recursive argument name to check type in fs.mkdir
Aug 31, 2018
99708c6
test: comment to check type for fsPromises.mkdir()
Aug 31, 2018
2299b07
test: fix fs.mkdir recursive option in test-fs-promises
Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: recursive argument name to check type in fs.mkdir
  • Loading branch information
Masashi Hirano committed Aug 31, 2018
commit df5ee0fca40593e782a9e41a31542468fbe709a9
10 changes: 5 additions & 5 deletions test/parallel/test-fs-mkdir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,23 +181,23 @@ if (common.isMainThread && (common.isLinux || common.isOSX)) {
// Anything else generates an error.
{
const pathname = path.join(tmpdir.path, nextdir());
['', 1, {}, [], null, Symbol('test'), () => {}].forEach((i) => {
['', 1, {}, [], null, Symbol('test'), () => {}].forEach((recursive) => {
common.expectsError(
() => fs.mkdir(pathname, { recursive: i }, common.mustNotCall()),
() => fs.mkdir(pathname, { recursive }, common.mustNotCall()),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "recursive" argument must be of type boolean. Received ' +
`type ${typeof i}`
`type ${typeof recursive}`
}
);
common.expectsError(
() => fs.mkdirSync(pathname, { recursive: i }),
() => fs.mkdirSync(pathname, { recursive }),
{
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "recursive" argument must be of type boolean. Received ' +
`type ${typeof i}`
`type ${typeof recursive}`
}
);
});
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-fs-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,15 +270,15 @@ function verifyStatObject(stat) {
// Anything else generates an error.
{
const dir = path.join(tmpDir, nextdir(), nextdir());
['', 1, {}, [], null, Symbol('test'), () => {}].forEach((i) => {
['', 1, {}, [], null, Symbol('test'), () => {}].forEach((recursive) => {
assert.rejects(
// mkdtemp() expects to get a string prefix.
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdtemp()?

Copy link
Copy Markdown
Contributor Author

@shisama shisama Aug 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, sorry. this is wrong copy and paste. Fixed this.

async () => mkdir(dir, { recursive: i }),
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small oversight: it should be recursive without : i

Copy link
Copy Markdown
Contributor Author

@shisama shisama Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review. I fixed this.

{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
message: 'The "recursive" argument must be of type boolean. ' +
`Received type ${typeof i}`
`Received type ${typeof recursive}`
}
);
});
Expand Down