Skip to content

src: fix external memory usage going negative #22594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mafintosh wants to merge 3 commits into from
Closed

src: fix external memory usage going negative #22594

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d783377
src: fix external memory usage going negative
mafintosh Aug 30, 2018
44dc6b5
fix nit
mafintosh Aug 30, 2018
8376f46
add common.mustCall
mafintosh Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add common.mustCall
  • Loading branch information
@mafintosh
mafintosh committed Aug 30, 2018
commit 8376f460c53cf3733728821bf4e3363105277d48
4 changes: 2 additions & 2 deletions test/parallel/test-gc-tls-external-memory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const server = net.createServer(function(socket) {
socket.write(yolo);
});

server.listen(0, function() {
server.listen(0, common.mustCall(function() {
const { port } = server.address();
let runs = 0;
connect();
Expand All @@ -32,4 +32,4 @@ server.listen(0, function() {
else
server.close();
}
});
}));