Skip to content

string_decoder : support typed array or data view #22562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BeniCheni wants to merge 7 commits into from
Closed

string_decoder : support typed array or data view #22562

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f14d9c
string_decoder: support typed array or data view
BeniCheni Aug 28, 2018
7505b48
string_decoder: update code format for ERR_INVALID_ARG_TYPE code area
BeniCheni Aug 28, 2018
3a25c6e
string_decoder: update source & tests for TypedArray & DataView per r…
BeniCheni Sep 1, 2018
9057575
doc: update .end & .write string_decoder.md
BeniCheni Sep 1, 2018
62393c0
test: update string-decoder tests w. ArrayBufferView
BeniCheni Sep 5, 2018
5fb3198
test: shorten test message in string-decoder tests w. ArrayBufferView
BeniCheni Sep 5, 2018
510ac79
test: remove console log message from string_decoder's ArrayBufferVie…
BeniCheni Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: remove console log message from string_decoder's ArrayBufferVie… 
…w tests

Refs: #22562 (comment)
  • Loading branch information
@BeniCheni
BeniCheni committed Sep 11, 2018
commit 510ac79d85b9c95446d7732beda9b8c9cab6aa26
4 changes: 0 additions & 4 deletions test/parallel/test-string-decoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,6 @@ assert.strictEqual(decoder.end(), '\ufffd');
const arrayBufferViewStr = 'String for ArrayBufferView tests\n';
const inputBuffer = Buffer.from(arrayBufferViewStr.repeat(8), 'utf8');
for (const expectView of common.getArrayBufferViews(inputBuffer)) {
console.log(
'string-decoder test for',
expectView[Symbol.toStringTag]
);
assert.strictEqual(
decoder.write(expectView),
inputBuffer.toString('utf8')
Expand Down