Skip to content

crypto: deduplicate public key parsing #22553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 2 commits into from
Closed

crypto: deduplicate public key parsing #22553

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9e25d
crypto: deduplicate public key parsing
tniessen Aug 5, 2018
c97927e
Address addaleax's comment
tniessen Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address addaleax's comment
  • Loading branch information
@tniessen
tniessen authored Aug 29, 2018
commit c97927eb09ad88d61e90e620dfac8b98f1a56981
4 changes: 2 additions & 2 deletions src/node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3648,11 +3648,11 @@ void Sign::SignFinal(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(rc);
}

typedef enum {
enum ParsePublicKeyResult {
kParsePublicOk,
kParsePublicNotRecognized,
kParsePublicFailed
} ParsePublicKeyResult;
};

static ParsePublicKeyResult ParsePublicKey(EVPKeyPointer* pkey,
const char* key_pem,
Expand Down