crypto: move process.binding('tls_wrap') internal

This commit makes the tls_wrap builtin an internal builtin, and changes usage of the builtin from using process.binding('tls_wrap') to use internalBinding instead. Refs: #22160
nodejs · danbev · Aug 21, 2018 · Aug 24, 2018 · e0c6943626e23245d27aa87def953a0ad3580498
commit e0c6943626e23245d27aa87def953a0ad3580498
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -32,9 +32,9 @@ const common = require('_tls_common');
 const { StreamWrap } = require('_stream_wrap');
 const { Buffer } = require('buffer');
 const debug = util.debuglog('tls');
-const tls_wrap = process.binding('tls_wrap');
 const { internalBinding } = require('internal/bootstrap/loaders');
 const { TCP, constants: TCPConstants } = internalBinding('tcp_wrap');
+const tls_wrap = internalBinding('tls_wrap');
 const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap');
 const { owner_symbol } = require('internal/async_hooks').symbols;
 const { SecureContext: NativeSecureContext } = internalBinding('crypto');

diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -353,7 +353,8 @@
         'signal_wrap',
         'crypto',
         'contextify',
-        'tcp_wrap']);
+        'tcp_wrap',
+        'tls_wrap']);
     process.binding = function binding(name) {
       return internalBindingWhitelist.has(name) ?
         internalBinding(name) :

diff --git a/src/tls_wrap.cc b/src/tls_wrap.cc
@@ -915,4 +915,4 @@ void TLSWrap::Initialize(Local<Object> target,
 
 }  // namespace node
 
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(tls_wrap, node::TLSWrap::Initialize)
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(tls_wrap, node::TLSWrap::Initialize)
diff --git a/test/parallel/test-tls-wrap-no-abort.js b/test/parallel/test-tls-wrap-no-abort.js
@@ -1,11 +1,13 @@
+// Flags: --expose-internals
 'use strict';
 
 const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
 
 const util = require('util');
-const TLSWrap = process.binding('tls_wrap').TLSWrap;
+const { internalBinding } = require('internal/test/binding');
+const TLSWrap = internalBinding('tls_wrap').TLSWrap;
 
 // This will abort if internal pointer is not set to nullptr.
 util.inspect(new TLSWrap());
diff --git a/test/sequential/test-async-wrap-getasyncid.js b/test/sequential/test-async-wrap-getasyncid.js
@@ -266,7 +266,7 @@ if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
   const credentials = require('tls').createSecureContext({ ca, cert, key });
 
   // TLSWrap is exposed, but needs to be instantiated via tls_wrap.wrap().
-  const tls_wrap = process.binding('tls_wrap');
+  const tls_wrap = internalBinding('tls_wrap');
   testInitialized(
     tls_wrap.wrap(tcp._externalStream, credentials.context, true), 'TLSWrap');
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -915,4 +915,4 @@ void TLSWrap::Initialize(Local<Object> target,

		} // namespace node

		NODE_BUILTIN_MODULE_CONTEXT_AWARE(tls_wrap, node::TLSWrap::Initialize)
		NODE_MODULE_CONTEXT_AWARE_INTERNAL(tls_wrap, node::TLSWrap::Initialize)