Skip to content

child_process: handling fork( path, undefined / null, obj ) #22416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shobhitchittora wants to merge 8 commits into from
Closed

child_process: handling fork( path, undefined / null, obj ) #22416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4ffbf08
child_process: handling fork( path, undefined / null, obj )
shobhitchittora Aug 20, 2018
deda17f
child_process: adds test + indentation fix
shobhitchittora Aug 22, 2018
331ecbe
child_process: fixes typo + lint fix
shobhitchittora Aug 22, 2018
262c9c1
child_process: refactored test as per the comments + alignment fix
shobhitchittora Aug 29, 2018
3889080
child_process: removes exit(0) from the test
shobhitchittora Sep 12, 2018
9d771cf
child_process: adding on exit handle
shobhitchittora Oct 3, 2018
ee71420
child_process: extending process.env
shobhitchittora Oct 10, 2018
2cf060d
child_process: adds test for null check
shobhitchittora Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
child_process: refactored test as per the comments + alignment fix
  • Loading branch information
@shobhitchittora
shobhitchittora committed Aug 29, 2018
commit 262c9c1e020f1de7291e8cddd46298106e66a309
4 changes: 2 additions & 2 deletions lib/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ exports.fork = function fork(modulePath /* , args, options */) {
args = arguments[pos++];
}

if (pos < arguments.length && (arguments[pos] === undefined ||
arguments[pos] === null)) {
if (pos < arguments.length &&
(arguments[pos] === undefined || arguments[pos] === null)) {
pos++;
}

Expand Down
12 changes: 6 additions & 6 deletions test/parallel/test-child-process-fork-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
/**
* fork should parse options correctly if args is undefined or null
*/

'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');

// This test ensures that fork should parse options
// correctly if args is undefined or null
Comment thread
shobhitchittora marked this conversation as resolved.

const assert = require('assert');
const { fork } = require('child_process');
const fixtures = require('../common/fixtures');

const expectedEnv = { foo: 'bar' };
const cp = fork(fixtures.path('child-process-echo-options.js'), undefined,
{ env: Object.assign({}, expectedEnv) });
Comment thread
shobhitchittora marked this conversation as resolved.
Outdated

cp.on('message', common.mustCall(function({ env }) {
cp.on('message', common.mustCall(({ env }) => {
assert.strictEqual(env.foo, expectedEnv.foo);
}));
Comment thread
lundibundi marked this conversation as resolved.
Outdated