Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
60c81c0
v8: add new to the throw statement
BridgeAR Jun 21, 2017
f56a4ba
process: Send signal name to signal handlers
robertrossmann Sep 25, 2017
08ccba7
doc: `readable.push(undefined)` in non-object mode
Jan 21, 2018
88adf76
doc: add process.debugPort to doc/api/process.md
flickz Feb 11, 2018
632f277
doc: make the background section concise and improve its formality
Feb 22, 2018
6456de8
src: fix error message in async_hooks constructor
danbev Feb 26, 2018
ac34737
http: prevent aborted event when already completed
billywhizz Feb 17, 2018
33cd733
http: prevent aborted event when already completed
billywhizz Feb 17, 2018
b80c59b
test: refactor test after review
billywhizz Feb 27, 2018
eb03707
test: specify 'dir' for directory symlinks
kfarnung Feb 27, 2018
2320afd
doc: add RegExp Unicode Property Escapes to intl
vsemozhetbyt Feb 28, 2018
3f0973f
doc: Readable unpipe on Writable error event
GeorgeSapkin Feb 8, 2018
aaa6fe5
doc: update list of re-exported symbols
richardlau Feb 26, 2018
8f6b0bd
doc: add URL.format() example
zeke Feb 20, 2018
2552af9
doc: add simple example to rename function
punteek Feb 16, 2018
472874d
doc: remove tentativeness in pull-requests.md
Trott Mar 4, 2018
d661a63
doc: remove subsystem from pull request template
Trott Mar 4, 2018
7f7e993
test: move require http2 to after crypto check
danbev Mar 3, 2018
85d8d22
src: #include <stdio.h>" to iculslocs
srl295 Mar 5, 2018
2ae1048
perf_hooks: fix timing
TimothyGu Feb 25, 2018
2578cdb
test: add more information to assert.strictEqual
ryzokuken Mar 6, 2018
2bb3600
doc: make suggestion more direct in stream.md
Trott Mar 4, 2018
d875750
test: skip postmortem metadata test when nm fails
joyeecheung Mar 3, 2018
5ff1828
doc: add inspector usage example
ofrobots Mar 6, 2018
b7ae752
doc: remove warning against readable/readable.read
Trott Mar 7, 2018
468a289
crypto: use bool over int consistently
tniessen Mar 8, 2018
b3e4775
test: refactor http-https-default-ports
ken23421 Mar 4, 2018
6539227
test: address unreliable test-performance
Trott Mar 8, 2018
e39c12a
test: do not check text for engine-generated error
Trott Mar 8, 2018
ac6f9d5
doc: add warning to assert.doesNotThrow()
BridgeAR Feb 10, 2018
8c206d7
repl: better handling of recoverable errors
princejwesley Feb 21, 2018
cf5c370
test: Remove unnecessary asserion messages in test-crypto-hash.js
pgrzesik Feb 25, 2018
e4accb6
test: fix test-abort-backtrace in shared lib build
yhwang Mar 7, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: remove tentativeness in pull-requests.md
There are some uses of "in general" that are unnecessary. (We don't need
to be tentative about the fact that tests should pass, for example.)

PR-URL: #19123
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and jasnell committed Aug 17, 2018
commit 472874dcfa923999936c72faafd1df283b32ca40
12 changes: 6 additions & 6 deletions doc/guides/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,10 @@ seem unfamiliar, refer to this
All Pull Requests require "sign off" in order to land. Whenever a contributor
reviews a Pull Request they may find specific details that they would like to
see changed or fixed. These may be as simple as fixing a typo, or may involve
substantive changes to the code you have written. In general, such requests
are intended to be helpful, but at times may come across as abrupt or unhelpful,
especially requests to change things that do not include concrete suggestions
on *how* to change them.
substantive changes to the code you have written. While such requests are
intended to be helpful, they may come across as abrupt or unhelpful, especially
requests to change things that do not include concrete suggestions on *how* to
change them.

Try not to be discouraged. If you feel that a particular review is unfair,
say so, or contact one of the other contributors in the project and seek their
Expand Down Expand Up @@ -610,8 +610,8 @@ however, will stay intact on the Pull Request page.
For the size of "one logical change",
[0b5191f](https://github.com/nodejs/node/commit/0b5191f15d0f311c804d542b67e2e922d98834f8)
can be a good example. It touches the implementation, the documentation,
and the tests, but is still one logical change. In general, the tests should
always pass when each individual commit lands on the master branch.
and the tests, but is still one logical change. All tests should always pass
when each individual commit lands on the master branch.

### Getting Approvals for Your Pull Request

Expand Down