Skip to content

build: touch tools/doc/node_modules after run #22350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 1 commit into from
Closed

build: touch tools/doc/node_modules after run #22350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: touch tools/doc/node_modules after run 
Currently, tools/doc/node_modules is not touched after running npm
install resulting in npm install being run every time. I missed this
while testing commit 88bff82 ("build:
make tools/doc/node_modules non-phony").
  • Loading branch information
@danbev @Trott
danbev authored and Trott committed Aug 18, 2018
commit 8833d8f7bf7e7793dc35d440975889e7e861f20e
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,6 +1073,7 @@ lint-md-build: tools/remark-cli/node_modules \
tools/doc/node_modules: tools/doc/package.json
ifeq ($(node_use_openssl),true)
cd tools/doc && $(call available-node,$(run-npm-install))
@touch $@
else
@echo "Skipping tools/doc/node_modules (no crypto)"
endif
Expand Down