Skip to content

src: extract common DoBind and DoConnect methods #22315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maclover7 wants to merge 2 commits into from
Closed

src: extract common DoBind and DoConnect methods #22315

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0697900
src: extract common Bind method
maclover7 Aug 14, 2018
c55c6b2
fixup: indutny style comment
maclover7 Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: indutny style comment
  • Loading branch information
@maclover7
maclover7 committed Dec 17, 2018
commit c55c6b20c0a5feb212b97664b7303d87eb58a50c
4 changes: 3 additions & 1 deletion src/tcp_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@ void TCPWrap::Bind(
unsigned int flags = 0;
if (!args[1]->Int32Value(env->context()).To(&port)) return;
if (family == AF_INET6 &&
!args[2]->Uint32Value(env->context()).To(&flags)) return;
!args[2]->Uint32Value(env->context()).To(&flags)) {
return;
}

T addr;
int err = uv_ip_addr(*ip_address, port, &addr);
Expand Down