Skip to content

os: move process.binding('os') to internalBinding #22292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
briete wants to merge 2 commits into from
Closed

os: move process.binding('os') to internalBinding #22292

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4a47c6
os: move process.binding('os') to internalBinding
briete Aug 13, 2018
ca7dad0
fixup! move test-os-checked-function to internalBinding
lundibundi Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! move test-os-checked-function to internalBinding
  • Loading branch information
@lundibundi
lundibundi committed Aug 29, 2018
commit ca7dad0abfe7463b3f9c843f2e2af33d73c98f82
6 changes: 5 additions & 1 deletion test/parallel/test-os-checked-function.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
// Flags: --expose-internals
'use strict';

const { internalBinding } = require('internal/test/binding');

// Monkey patch the os binding before requiring any other modules, including
// common, which requires the os module.
process.binding('os').getHomeDirectory = function(ctx) {
internalBinding('os').getHomeDirectory = function(ctx) {
ctx.syscall = 'foo';
ctx.code = 'bar';
ctx.message = 'baz';
Expand Down