Skip to content

process: wrap process.binding for selective fallthrough to internalBinding #22269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
+24 −0
Closed

process: wrap process.binding for selective fallthrough to internalBinding #22269

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0ba27b
process: wrap process.binding for selective deprecation
jasnell Aug 11, 2018
7e4af61
[Squash] address feedback
jasnell Aug 13, 2018
758fcf3
[Squash] lint
jasnell Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Squash] address feedback
  • Loading branch information
@jasnell
jasnell committed Aug 13, 2018
commit 7e4af610e5d98302e28ef2560c8386718bd4c617
21 changes: 9 additions & 12 deletions lib/internal/bootstrap/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,20 +321,17 @@

// Deprecated specific process.binding() modules, but not all, allow
// selective fallback to internalBinding for the deprecated ones.
const { SafeSet } = NativeModule.require('internal/safe_globals');
const processBinding = process.binding;
const internalBindingWhitelist = new Set(['uv']);
const internalBindingWarned = new Set();
// internalBindingWhitelist contains the name of internalBinding modules
// that are whitelisted for access via process.binding()... this is used
// to provide a transition path for modules that are being moved over to
// internalBinding.
const internalBindingWhitelist = new SafeSet(['uv']);
process.binding = function binding(name) {
if (internalBindingWhitelist.has(name)) {
if (!internalBindingWarned.has(name)) {
process.emitWarning(
`Use of process.binding('${name}') is deprecated.`,
'DeprecationWarning', 'DEP0111');
internalBindingWarned.add(name);
}
return internalBinding(name);
}
return processBinding(name);
return internalBindingWhitelist.has(name) ?
internalBinding(name) :
processBinding(name);
};
}

Expand Down
8 changes: 2 additions & 6 deletions ...allel/test-process-binding-deprecation.js → ...cess-binding-internalbinding-whitelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
const common = require('../common');
const assert = require('assert');

common.expectWarning(
'DeprecationWarning',
'Use of process.binding(\'uv\') is deprecated.',
'DEP0111'
);

// Assert that whitelisted internalBinding modules are accessible via
// process.binding().
assert(process.binding('uv'));