Skip to content

lib: Remove unused param for filterInternalStackFrames #22267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

lib: Remove unused param for filterInternalStackFrames #22267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: Remove unused param for filterInternalStackFrames 
Actually we don't refer the `error` directly in
`filterInternalStackFrames`, so just remove it anyway.
  • Loading branch information
MaleDong committed Aug 11, 2018
commit 2a33764b1922818ab9f6d6bdf76cf972462b02da
4 changes: 2 additions & 2 deletions lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ function REPLServer(prompt,
self.writer.options = Object.assign({}, writer.options, { colors: true });
}

function filterInternalStackFrames(error, structuredStack) {
function filterInternalStackFrames(structuredStack) {
// Search from the bottom of the call stack to
// find the first frame with a null function name
if (typeof structuredStack !== 'object')
Expand All @@ -509,7 +509,7 @@ function REPLServer(prompt,

function prepareStackTrace(fn) {
return (error, stackFrames) => {
const frames = filterInternalStackFrames(error, stackFrames);
const frames = filterInternalStackFrames(stackFrames);
if (fn) {
return fn(error, frames);
}
Expand Down