Skip to content

tools: install doc tools only when necessary #22217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 1 commit into from
Closed

tools: install doc tools only when necessary #22217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: install doc tools only when necessary 
Marking tools/doc/node_modules as PHONY result in constant
installation of the doctools whether it's changed or not
(which means `make lint-addon-docs` always install the tools).
Unmark it and fix the dependency to avoid unnecessary
installations if the package.json is not changed.
  • Loading branch information
@joyeecheung
joyeecheung committed Aug 9, 2018
commit a9969758cbf5f3450db61cc58b501b4629e94141
3 changes: 1 addition & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,8 +1060,7 @@ lint-md-build: tools/remark-cli/node_modules \
tools/doc/node_modules \
tools/remark-preset-lint-node/node_modules

.PHONY: tools/doc/node_modules
tools/doc/node_modules:
tools/doc/node_modules: tools/doc/package.json
@cd tools/doc && $(call available-node,$(run-npm-install))

.PHONY: lint-md
Expand Down