Skip to content

Don't set -fno-threadsafe-statics on macOS as build option #22198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kylef wants to merge 1 commit into from
Closed

Don't set -fno-threadsafe-statics on macOS as build option #22198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: Don't set -fno-threadsafe-statics on macOS 
This flag is not set on other platforms so it can produce inconsistent
behaviour across platforms. For example, if you build an async node add-on
which uses statics you can get race conditions due to static not supporting
threads if the node add-on inherits from the Node common.gypi config. It is not
disabled on other platforms such as Linux, it is not disabled by default in
Xcode or clang.

This setting has been there since the initial commit that introduces
`common.gypi` and thus has been there since the start, it doesn't seem to be
have added for any particular reason other than to potentially match the Xcode
defaults at the time.
  • Loading branch information
@kylef
kylef authored Aug 8, 2018
commit 595114aa769c254894af4ffffd7d9d21446b38ec
1 change: 0 additions & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,6 @@
'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions
'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti
'GCC_ENABLE_PASCAL_STRINGS': 'NO', # No -mpascal-strings
'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics
'PREBINDING': 'NO', # No -Wl,-prebind
'MACOSX_DEPLOYMENT_TARGET': '10.7', # -mmacosx-version-min=10.7
'USE_HEADERMAP': 'NO',
Expand Down