Skip to content

test: remove second arg from assert.ifError() #22190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhamwala wants to merge 1 commit into from
Closed

test: remove second arg from assert.ifError() #22190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove second arg from assert.ifError() 
`test/parallel/test-fs-readfile.js` has a call to `assert.ifError()` that receives two arguments.
There is no second argument used in `assert.ifError()`. This PR removes this argument.
  • Loading branch information
@mhamwala
mhamwala committed Aug 8, 2018
commit 89e5892ca78d7eb72621f56f06fdb19468de7672
2 changes: 1 addition & 1 deletion test/parallel/test-fs-readfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ for (const e of fileInfo) {
for (const e of fileInfo) {
fs.readFile(e.name, common.mustCall((err, buf) => {
console.log(`Validating readFile on file ${e.name} of length ${e.len}`);
assert.ifError(err, 'An error occurred');
assert.ifError(err);
assert.deepStrictEqual(buf, e.contents, 'Incorrect file contents');
}));
}