Skip to content

src: remove calls to deprecated v8 functions (Uint32Value) #22143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryzokuken wants to merge 9 commits into from
Closed

src: remove calls to deprecated v8 functions (Uint32Value) #22143

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4f11f8f
src: remove calls to deprecated v8 functions (Uint32Value)
ryzokuken Aug 29, 2018
14afa7d
fixup! some nits
targos Aug 29, 2018
ccfe17d
fixup! always uint32
targos Sep 1, 2018
b19df2e
fixup! typo
targos Sep 2, 2018
7cdabd5
fixup! return-on-error
targos Sep 2, 2018
f8219c4
fix warnings in zlib
targos Sep 2, 2018
05aa50f
fixup! revert to casting in Buffer::Fill
targos Sep 2, 2018
58156f9
fixup! coerce to uint32 before calling indexOf
targos Sep 2, 2018
0bf15c5
fixup! zlib
targos Sep 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! some nits
  • Loading branch information
@targos
targos committed Sep 2, 2018
commit 14afa7dcfdb699db0fa21dcfb903d3b67bc1b925
13 changes: 7 additions & 6 deletions src/node_buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,15 +564,16 @@ void Copy(const FunctionCallbackInfo<Value> &args) {

void Fill(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
Local<Context> ctx = env->context();

THROW_AND_RETURN_UNLESS_BUFFER(env, args[0]);
SPREAD_BUFFER_ARG(args[0], ts_obj);

Local<Context> ctx = env->context();
uint32_t start, end;
if (!args[2]->Uint32Value(ctx).To(&start) ||
!args[3]->Uint32Value(ctx).To(&end))
return;
CHECK(args[2]->IsUint32());
CHECK(args[3]->IsUint32());

uint32_t start = args[2].As<Uint32>()->Value();
uint32_t end = args[3].As<Uint32>()->Value();
size_t fill_length = end - start;
Local<String> str_obj;
size_t str_length;
Expand Down Expand Up @@ -1004,7 +1005,7 @@ void IndexOfBuffer(const FunctionCallbackInfo<Value>& args) {
}

void IndexOfNumber(const FunctionCallbackInfo<Value>& args) {
CHECK(args[1]->IsNumber());
CHECK(args[1]->IsUint32());
CHECK(args[2]->IsNumber());
CHECK(args[3]->IsBoolean());

Expand Down