Skip to content

util, assert: improve array comparison performance #22111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 5 commits into from
Closed

util, assert: improve array comparison performance #22111

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c350d3e
benchmark: improve assert benchmarks
BridgeAR Aug 3, 2018
211b086
util,assert: improve performance
BridgeAR Aug 3, 2018
98a4f90
util,assert: fix boxed primitives bug
BridgeAR Aug 3, 2018
a93b55c
test: improve test coverage for comparisons
BridgeAR Aug 3, 2018
778a2b1
fixup: benchmark commit
BridgeAR Aug 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
util,assert: improve performance 
This adds a smarter logic to compare object keys and it also skips
the object key comparison for arrays, if possible.

Besides that it adds a fast path for empty objects and arrays.

It also adds a fast path for boxed strings and improves the
comparison performance for TypedArrays with extra keys on the object.

On top of that a few functions are now safer to call by using
uncurryThis and by caching the actual function.
  • Loading branch information
@BridgeAR
BridgeAR committed Aug 3, 2018
commit 211b086427124fe1135f2498af1fa4c0fecc09c1
Loading