Skip to content

util: support BigInt in util.format #22097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shisama wants to merge 4 commits into from
Closed

util: support BigInt in util.format #22097

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08f67c4
util: support BigInt in util.format
Aug 2, 2018
932002c
util: %i supports BigInt
Sep 16, 2018
097ba59
util: update util.md that supports BigInt
Sep 18, 2018
946fdec
util: add tests to check multiple %d/%i specifiers for BigInt
Sep 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
util: update util.md that supports BigInt
  • Loading branch information
Masashi Hirano committed Sep 18, 2018
commit 097ba592f309360c9d67ccb68eb0429452fc6bfc
2 changes: 1 addition & 1 deletion doc/api/util.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ corresponding argument. Supported placeholders are:

* `%s` - `String`.
* `%d` - `Number` (integer or floating point value) or `BigInt`.
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung Aug 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anything, shouldn't %i be more suitable for BigInt, considering it's an integer?

* `%i` - Integer.
* `%i` - Integer or `BigInt`.
* `%f` - Floating point value.
* `%j` - JSON. Replaced with the string `'[Circular]'` if the argument
contains circular references.
Expand Down